From a99679eda506b32d7f7cf9de12ce1cce131808e0 Mon Sep 17 00:00:00 2001 From: Christoph Stahl Date: Fri, 15 Nov 2024 22:20:49 +0100 Subject: [PATCH] Fixed a bug that could deadlock the player --- syng/sources/source.py | 2 ++ syng/sources/youtube.py | 1 + 2 files changed, 3 insertions(+) diff --git a/syng/sources/source.py b/syng/sources/source.py index 63c689f..c7c04e7 100644 --- a/syng/sources/source.py +++ b/syng/sources/source.py @@ -154,6 +154,7 @@ class Source(ABC): "mpv", *args, stdout=asyncio.subprocess.PIPE, + stderr=asyncio.subprocess.PIPE, ) return await mpv_process @@ -306,6 +307,7 @@ class Source(ABC): self.downloaded_files[entry.ident].audio, *extra_options, ) + await self.player.communicate() await self.player.wait() self.player = None if self._skip_next: diff --git a/syng/sources/youtube.py b/syng/sources/youtube.py index b6d9d8e..3ba58a6 100644 --- a/syng/sources/youtube.py +++ b/syng/sources/youtube.py @@ -257,6 +257,7 @@ class YoutubeSource(Source): "--fullscreen", mpv_options, ) + await self.player.communicate() await self.player.wait() else: await super().play(entry, mpv_options)