No description
0bc12e1c67
I made the mistake of using the same variable name _offset for the temporary variable in WORD16 and WORD32, and for the one in BYTE which the other two use as a subroutine - meaning that the declaration on the first line of BYTE read 'size_t _offset = _offset+3' or similar, in which the RHS _offset referred to the newly declared LHS one rather than to the one in the outer scope. WORD32 had the additional goof that I had declared its return-value accumulator variable as a 16- rather than 32-bit integer due to copy-and-paste error. Between those two mistakes - surely introduced at the last minute when I was doing code cleanup on this source base, because I know this function was working OK before then - I had completely broken the extraction of version strings from PE executables. |
||
|---|---|---|
| .gitignore | ||
| api.h | ||
| autogen.sh | ||
| configure.ac | ||
| dupstr.c | ||
| dupstr.h | ||
| makecab.c | ||
| makecab.py | ||
| Makefile.am | ||
| makemsi.c | ||
| md5.c | ||
| memory.c | ||
| memory.h | ||
| misc.h | ||
| preload.c | ||
| readcab.c | ||
| subproc.c | ||
| subproc.h | ||
| test.c | ||
| uchars.c | ||
| uchars.h | ||
| version.c | ||
| winterop-stubs.c | ||
| wrapper.py | ||